Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(parsers): Fix to include new Adani import column in BD data #7154

Merged
merged 6 commits into from
Sep 6, 2024

Conversation

annaib00
Copy link
Contributor

@annaib00 annaib00 commented Sep 4, 2024

Issue

New Adani import column in data for BD

Description

Fixed parser to handle the new Adani import column and take this into account in exchange with IN-EA. The column is NoneType before the 28th of august 2024.

Preview

Double check

  • I have tested my parser changes locally with poetry run test_parser "zone_key"
  • I have run pnpx prettier@2 --write . and poetry run format in the top level directory to format my changes.

@github-actions github-actions bot added parser python Pull requests that update Python code labels Sep 4, 2024
Copy link
Member

@FelixDQ FelixDQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion for slightly more readable code, but otherwise it LGTM

parsers/ERP_PGCB.py Outdated Show resolved Hide resolved
@github-actions github-actions bot added the tests label Sep 6, 2024
parsers/test/mocks/ERP_PGCB/latest.html Dismissed Show dismissed Hide dismissed
parsers/test/mocks/ERP_PGCB/latest.html Dismissed Show dismissed Hide dismissed
parsers/test/mocks/ERP_PGCB/latest.html Dismissed Show dismissed Hide dismissed
@annaib00 annaib00 enabled auto-merge (squash) September 6, 2024 07:36
@annaib00 annaib00 merged commit c4f9047 into master Sep 6, 2024
19 checks passed
@annaib00 annaib00 deleted the annaboye/gmm-149-bd-is-down branch September 6, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parser python Pull requests that update Python code tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants