Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Z-indexes #7279

Merged
merged 2 commits into from
Oct 7, 2024
Merged

Refactor: Z-indexes #7279

merged 2 commits into from
Oct 7, 2024

Conversation

cadeban
Copy link
Contributor

@cadeban cadeban commented Oct 4, 2024

Description

Refactor app z-indexes.

Preview

Previously encountered this issue:
Screenshot 2024-09-30 at 11 20 28

Now, with all layers present:
Screenshot 2024-09-30 at 20 22 11

Will probably need to do some follow up on this at some point, since it would be nice for the toasts to have their own isolated stacking context and not influenced by a parent element's stacking context:

Screenshot 2024-10-04 at 10 13 39

Double check

  • I have tested my parser changes locally with poetry run test_parser "zone_key"
  • I have run pnpx prettier@2 --write . and poetry run format in the top level directory to format my changes.

Copy link
Member

@VIKTORVAV99 VIKTORVAV99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT! 🎉

web/src/features/panels/LeftPanel.tsx Show resolved Hide resolved
@cadeban cadeban merged commit fb9efb0 into master Oct 7, 2024
22 checks passed
@cadeban cadeban deleted the cadeban/refactor-zindex branch October 7, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants