Consolidate ChartTitle and BySource components #7353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cadeban
force-pushed
the
cadeban/consolidate-chart-headers
branch
from
460a608
to
a6e5cb2
Compare
cadeban
changed the title
VIKTORVAV99
approved these changes
Oct 25, 2024
2 tasks
cadeban
force-pushed
the
cadeban/consolidate-chart-headers
branch
from
1c9d063
to
4b0b63d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BySource and ChartTitle components share overlapping functionality and visual design; therefore it makes sense to consolidate them and have a single component for all chart titles. Follow up to #7346 (comment).
Preview
Visuals should match:
Double check
poetry run test_parser "zone_key"pnpx prettier@2 --write .andpoetry run formatin the top level directory to format my changes.