Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: optimize object creation in ExchangeArrow.tsx #7624

Merged
merged 3 commits into from
Jan 27, 2025
Merged

perf: optimize object creation in ExchangeArrow.tsx #7624

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0859bc9
perf: optimize object creation in ExchangeArrow.tsx
VIKTORVAV99 Dec 27, 2024
ec3d0ed
rename variables to be more clear
VIKTORVAV99 Jan 27, 2025
abe23b3
Merge branch 'master' into vik/optimize_object_creation_in_ExchangeArrow
VIKTORVAV99 Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 11 additions & 15 deletions web/src/features/exchanges/ExchangeArrow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,29 +108,26 @@ function ExchangeArrow({
}

const mapZoom = map.getZoom();
const projection = map.project(lonlat);
const transform = {
x: projection.x,
y: projection.y,
k: 0.04 + (mapZoom - 1.5) * 0.1,
r: rotation + (netFlow > 0 ? 180 : 0),
};
const { x, y } = map.project(lonlat);
const k = 0.04 + (mapZoom - 1.5) * 0.1;
const r = rotation + (netFlow > 0 ? 180 : 0);
const factor = 100 * k;
VIKTORVAV99 marked this conversation as resolved.
Show resolved Hide resolved

// Setting the top position from the arrow tooltip preventing overflowing to top.
let tooltipClassName =
'max-h-[256px] max-w-[512px] md:flex rounded-2xl border-neutral-200 bg-white dark:bg-gray-900 dark:border-gray-700 dark:border';
if (!isMobile) {
tooltipClassName += transform.y - 76 < headerHeight ? ' top-[76px]' : ' top-[-76px]';
tooltipClassName += y - 76 < headerHeight ? ' top-[76px]' : ' top-[-76px]';
}

if (
// or if the arrow would be very tiny
transform.k < 0.1 ||
k < 0.1 ||
// or if it would be rendered outside of viewport.
transform.x + 100 * transform.k < 0 ||
transform.y + 100 * transform.k < 0 ||
transform.x - 100 * transform.k > viewportWidth ||
transform.y - 100 * transform.k > viewportHeight
x + factor < 0 ||
y + factor < 0 ||
x - factor > viewportWidth ||
y - factor > viewportHeight
) {
return null;
}
Expand All @@ -150,9 +147,8 @@ function ExchangeArrow({
sideOffset={10}
>
<picture
id={key}
style={{
transform: `translateX(${transform.x}px) translateY(${transform.y}px) rotate(${transform.r}deg) scale(${transform.k})`,
transform: `translateX(${x}px) translateY(${y}px) rotate(${r}deg) scale(${k})`,
cursor: 'grab',
overflow: 'hidden',
position: 'absolute',
Expand Down
Loading