-
Notifications
You must be signed in to change notification settings - Fork 969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix/feat(parsers, MN): fix json parsing error and add coal data #7735
Conversation
# Calculated 'unknown' production from available data (consumption, import, solar, wind, tpp). | ||
# 'unknown' consists of 92.8% coal, 5.8% oil and 1.4% hydro as per 2020; sources: IEA and IRENA statistics. | ||
query_data["leftoverMW"] = round( | ||
query_data["consumptionMW"] | ||
- query_data["importMW"] | ||
- query_data["solarMW"] | ||
- query_data["windMW"], | ||
13, | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This calculation maps exactly to the dts
value, which is presented in the website https://ndc.energy.mn/ as:
Due to this, I figure it should be used directly. If it should be coal or unknown is not in any way obvious in my mind - whats clear is that Mongolia is mostly using coal though, and they didn't mind reporting this as some kind of fossil power plant with the icon.
ed1823f
to
ceaf273
Compare
Force pushed a rebase on master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉
Issue
For #5906 that should resolve after a while if it works by its own.
Description
The JSON API used had a new format which broke the parser.
Songino
as it wasn't obvious enough what to do about it, but it could be battery storage perhaps based on the icon, see discussion following MN production parser down #5906 (comment).Highlighted decision
dts
tocoal
, even without understanding whatdts
refers to.unknown
calculation was calculating the same valuedts
is set todts
represents based on the icon for it in https://ndc.energy.mn/Double check
poetry run test_parser "zone_key"
pnpx prettier@2 --write .
andpoetry run format
in the top level directory to format my changes.