fix/tests(parsers, DO): adopt use_proxy decorator that makes things work again, and add snapshot test #7741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - Makes calling `fetch_production()` without args or kwargs not run into issues stemming from `zone_key` being explicitly passed as None. - Adds a comment on what webshare.io subscription is useful for use by this project. - Re-configures session.proxies back to what it was in a way that I think now will work, while previously I think we just stored a reference to the proxies object that we then also modified. This likely won't impact anyone. - Adjusted the code for readability, which is an opinionated matter of course.
github-actions
bot
added
parser
python
consideRatio
changed the title
VIKTORVAV99
approved these changes
Jan 23, 2025
2 tasks
|
No worries @VIKTORVAV99 i recognize your situation, thank you for taking time to review! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Description
use_proxyas that makes the request to the data source succeed instead of time outuse_proxyis required and people typically won't have a webshare.io account, and it then helps anyone to test code changes against the mocked responseDouble check
poetry run test_parser "zone_key"pnpx prettier@2 --write .andpoetry run formatin the top level directory to format my changes.