Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(zone-configs): add historical capacities for US-NW-AVA #7800

Conversation

silkeholmebonnen
Copy link
Contributor

@silkeholmebonnen silkeholmebonnen commented Feb 3, 2025

Issue

Context from this PR

Description

This PR adds historical capacities for US-NW-AVA so the outliers from 2019 and 2020 will hopefully be detected.

TODO after this PR has been merged

Double check

  • I have tested my parser changes locally with poetry run test_parser "zone_key"
  • I have run pnpx prettier@2 --write . and poetry run format in the top level directory to format my changes.

@github-actions github-actions bot added the zone config Pull request or issue for zone configurations label Feb 3, 2025
Comment on lines 58 to 63
- datetime: '2019-01-01'
source: EIA.gov
value: 105.3
- datetime: '2023-10-01'
source: EIA.gov
value: 249.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we try and add some more wind data so we don't accidentally flag data between 2019-01-01 and 2023-10-01?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Should i just run the capacity_update script for all the years between 2019 and 2023 ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that sounds good.

Copy link
Member

@VIKTORVAV99 VIKTORVAV99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@silkeholmebonnen silkeholmebonnen merged commit 551e159 into master Feb 3, 2025
22 checks passed
@silkeholmebonnen silkeholmebonnen deleted the silkebonnen/update-historical-capacitites-for-US-NW-AVA branch February 3, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
zone config Pull request or issue for zone configurations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants