Fix: New OLEDs (SSD1327 & SSD1351) were still using old GPIO #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't have either of these devices on hand, but I did modify the existing SSD130x example to use each display instead, and was able to compile without errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated oleds ssd1327 and ssd1351 to modern Pin/GPIO API
Out of the scope of this quick-fix, but it looks like the Transport class for all three of the SSD13xx drivers in the library are all identical. So a minor refactor would help reduce the opportunity for similar regressions in the future (as would examples for each driver).