fix(hmr): subapp v1 (#2024)

Co-authored-by: shubham2811 <shubham.sharma3@walmart.com>
electrode-io · Sep 6, 2024 · 16ebc15 · 16ebc15
1 parent a2aff6e
commit 16ebc15
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 2 deletions.
diff --git a/common/changes/subapp-web/fix-hmr-subappV1_2024-09-06-16-32.json b/common/changes/subapp-web/fix-hmr-subappV1_2024-09-06-16-32.json
@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "subapp-web",
+      "comment": "fix hmr error",
+      "type": "patch"
+    }
+  ],
+  "packageName": "subapp-web"
+}
diff --git a/packages/subapp-web/src/index.js b/packages/subapp-web/src/index.js
@@ -91,7 +91,7 @@ export function loadSubApp(info, renderStart, options) {
   subApp.start = (instance, options, info) => {
     instance = instance || subApp.preStart(instance, options, info);
     info = info || subApp.info;
-    if (instance && !instance.props) {
+    if (instance && !instance.props && options) {
       instance.props = options.props;
     }
     // if user provided a start function, then user is expected to
@@ -187,7 +187,16 @@ export function isLoaded(name) {
   return Boolean(xarc.getSubApp(name));
 }
 
-export function lazyLoadSubApp({ name, id, timeout = 15000, onLoad, onError, fallback, ns, props }) {
+export function lazyLoadSubApp({
+  name,
+  id,
+  timeout = 15000,
+  onLoad,
+  onError,
+  fallback,
+  ns,
+  props
+}) {
   // TODO: timeout and callback
   const lname = name.toLowerCase();