[minor] Jest support #775
Merged
[minor] Jest support #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
didi0613
commented
May 2, 2018
•
didi0613
commented
- jest config extenable from app level
- auto detect jest unit tests, can run karma unit tests in parallel
didi0613
force-pushed
the
jest-test-support
branch
from
ed772e5
to
d78cb21
Compare
datvong-wm
approved these changes
May 7, 2018
jchip
requested changes
May 7, 2018
| const Path = require("path"); | ||
| const optionalRequire = require("optional-require")(require); | ||
|
|
||
| const rootDir = Path.join(Path.resolve("node_modules"), ".."); |
| const optionalRequire = require("optional-require")(require); | ||
|
|
||
| const rootDir = Path.join(Path.resolve("node_modules"), ".."); | ||
| const devPkgPath = Path.join( |
There was a problem hiding this comment.
basically Path.join(__dirname, "../..")
| const srcJestFiles = glob.sync(`${Path.resolve(AppMode.src.dir)}/**/\*.{test,spec}.{js,jsx}`); | ||
|
|
||
| if (shell.test("-d", "_test_") || srcJestFiles.length > 0) { | ||
| console.log(`\n*** Running jest unit tests: ***\n`); |
|
|
||
| if (shell.test("-d", "_test_") || srcJestFiles.length > 0) { | ||
| console.log(`\n*** Running jest unit tests: ***\n`); | ||
| return exec( |
There was a problem hiding this comment.
use
mkCmd( `~$jest`, `--config ${archetype.config.jest}/jest.config.js`)
| ), | ||
| "karma-test-frontend-cov": () => { | ||
| if (shell.test("-d", "test")) { | ||
| console.log(`\n*** Running karma unit tests: ***\n`); |
There was a problem hiding this comment.
avoid console.log. we have a logger.
| "karma-test-frontend-cov": () => { | ||
| if (shell.test("-d", "test")) { | ||
| console.log(`\n*** Running karma unit tests: ***\n`); | ||
| return exec( |
…to jest-test-support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.