Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[patch] Clean up app generator unused css class names & take inline styles out #856

Merged
merged 3 commits into from
Jul 14, 2018
Merged

[patch] Clean up app generator unused css class names & take inline styles out #856

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3a2bc79
Clean up app generator unused css class names & take inline styles out
didi0613 Jul 11, 2018
f0fc5f2
remove unsed var
didi0613 Jul 11, 2018
fa47717
remove unnecessary styles import
didi0613 Jul 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions ...s/generator-electrode/generators/app/templates/src/client/components/demo-pure-states.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,19 +15,17 @@ const DemoPureStates = props => {
<div>
<h6 className={custom["docs-header"]}>Demo Managing States in Pure Functional Component</h6>
<label
style={{ display: "inline-block", textAlign: "center" }}
className={custom["checkbox-label"]}
onChange={() => dispatch(toggleCheck())}
checked={checked}
>
<input type="checkbox" checked={checked} onChange={() => null} />
<span className={custom["label-body"]}> checkbox </span>
<span> checkbox </span>
</label>
<div style={{ width: "10rem", display: "inline-block", textAlign: "center" }}>
{checked ? "checked" : "unchecked"}
</div>
<div className={custom["checkbox-label-width10rem"]}>{checked ? "checked" : "unchecked"}</div>
<div>
<button onClick={() => dispatch(decNumber())}>&#8810;</button>
<div style={{ width: "6rem", display: "inline-block", textAlign: "center" }}>{value}</div>
<div className={custom["checkbox-label-width6rem"]}>{value}</div>
<button onClick={() => dispatch(incNumber())}>&#8811;</button>
</div>
</div>
Expand Down
8 changes: 4 additions & 4 deletions packages/generator-electrode/generators/app/templates/src/client/components/demo-states.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,19 +11,19 @@ class DemoStates extends React.Component {
<div>
<h6 className={custom["docs-header"]}>Demo Managing States with Redux</h6>
<label
style={{ display: "inline-block", textAlign: "center" }}
className={custom["checkbox-label"]}
onChange={() => dispatch(toggleCheck())}
checked={checked}
>
<input type="checkbox" checked={checked} onChange={() => null} />
<span className={custom["label-body"]}> checkbox </span>
<span> checkbox </span>
</label>
<div style={{ width: "10rem", display: "inline-block", textAlign: "center" }}>
<div className={custom["checkbox-label-width10rem"]}>
{checked ? "checked" : "unchecked"}
</div>
<div>
<button onClick={() => dispatch(decNumber())}>&#8810;</button>
<div style={{ width: "6rem", display: "inline-block", textAlign: "center" }}>{value}</div>
<div className={custom["checkbox-label-width6rem"]}>{value}</div>
<button onClick={() => dispatch(incNumber())}>&#8811;</button>
</div>
</div>
Expand Down
2 changes: 1 addition & 1 deletion packages/generator-electrode/generators/app/templates/src/client/components/home.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export default () => (
{/*<% } %>*/}

<section className={custom.header}>
<h2 className={skeleton.title}>
<h2>
<span>Hello from </span>
<a href="https://github.com/electrode-io">
{"Electrode"}
Expand Down
23 changes: 21 additions & 2 deletions packages/generator-electrode/generators/app/templates/src/client/styles/custom.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,17 @@
.docs-header {
text-transform: uppercase;
font-size: 1.4rem;
letter-spacing: .2rem;
letter-spacing: 0.2rem;
font-weight: 600;
}
.docs-section {
border-top: 1px solid #eee;
padding: 4rem 0;
margin-bottom: 0;
}
.docs-example .row, .docs-example.row, .docs-example {
.docs-example .row,
.docs-example.row,
.docs-example {
margin-bottom: 0;
}
.docs-example h1,
Expand Down Expand Up @@ -63,3 +65,20 @@ img {
margin: 50px 0;
text-align: center;
}

.checkbox-label {
display: inline-block;
text-align: center;
}

.checkbox-label-width10rem {
width: 10rem;
display: inline-block;
text-align: center;
}

.checkbox-label-width6rem {
width: 6rem;
display: inline-block;
text-align: center;
}