fix(AppImage): app bin detection

electron-userland · Aug 5, 2016 · 06def89 · 06def89
1 parent 282fc72
commit 06def89
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 2 deletions.
diff --git a/.idea/inspectionProfiles/Project_Default.xml b/.idea/inspectionProfiles/Project_Default.xml
diff --git a/src/targets/appImage.ts b/src/targets/appImage.ts
@@ -45,7 +45,6 @@ export default class AppImageTarget extends TargetEx {
       "-map", await this.desktopEntry, `/${appInfo.name}.desktop`,
       "-move", `/usr/bin/${appInfo.productFilename}`, appExecutableImagePath,
       // http://stackoverflow.com/questions/13633488/can-i-store-unix-permissions-in-a-zip-file-built-with-apache-ant, xorriso doesn't preserve it for zip, but we set it in any case
-      "-chmod", "+x", appExecutableImagePath, "--",
       "-chmod", "+x", "/AppRun", appExecutableImagePath, "--",
     ]
     for (let [from, to] of (await this.helper.icons)) {

diff --git a/templates/linux/AppRun.sh b/templates/linux/AppRun.sh
@@ -128,7 +128,7 @@ check_dep xdg-desktop-menu
 
 DESKTOP_FILE=$(find "$APPDIR" -maxdepth 1 -name "*.desktop" | head -n 1)
 DESKTOP_FILE_NAME=$(basename "${DESKTOP_FILE}")
-APP=$(echo "$DESKTOP_FILE_NAME" | sed -e 's/.desktop//g')
+APP="${DESKTOP_FILE_NAME%.*}"
 BIN="$APPDIR/usr/bin/$APP"
 
 if [ ! -f "$DESKTOP_FILE" ] ; then