Merge pull request #76 from demetris-manikas/master

Added support for windows Unistall/DisplayVersion
electron-userland · Nov 24, 2015 · d01fe82 · d01fe82
2 parents f9499e2 + e097779
commit d01fe82
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 0 deletions.
diff --git a/README.md b/README.md
@@ -105,6 +105,7 @@ config.json.sample:
   },
   "win" : {
     "title" : "Loopline Systems",
+    "version" : "x.x.x.x",
     "icon" : "assets/win/icon.ico",
     "nsiTemplate" : "path/to/custom/installer.nsi.tpl"
   }
@@ -129,6 +130,9 @@ This property contains the configuration for the OSX dmg window. This property i
 ### `win.title`
 Title of your application shown in generated windows installer.
 
+### `win.version`
+Version of your application shown in add/remove programs list.
+
 ### `win.icon`
 Icon to be shown in installation process.
 

diff --git a/lib/win.js b/lib/win.js
@@ -32,6 +32,7 @@ var WinBuilder = {
     var configFilePath = writeConfigFile( nsiTemplate, {
       appPath : _windowsify( options.appPath ),
       name    : options.config.win.title,
+      version : options.config.win.version,
       out     : _windowsify( options.out )
     } );
 

diff --git a/templates/installer.nsi.tpl b/templates/installer.nsi.tpl
@@ -1,4 +1,5 @@
 !define APP_NAME "<%= name %>"
+!define APP_VERSION "<%= version %>"
 !define APP_DIR "${APP_NAME}"
 
 Name "${APP_NAME}"
@@ -58,6 +59,8 @@ Section
                    "UninstallString" "$INSTDIR\Uninstall ${APP_NAME}.exe"
   WriteRegStr HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\${APP_NAME}" \
                    "DisplayIcon" "$INSTDIR\icon.ico"
+  WriteRegStr HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\${APP_NAME}" \
+                   "DisplayVersion" "$APP_VERSION"
 SectionEnd
 
 # create a section to define what the uninstaller does