Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different names for ia32 and win64 nupkg #439

Closed
gamestailer94 opened this issue May 25, 2016 · 14 comments
Closed

Different names for ia32 and win64 nupkg #439

gamestailer94 opened this issue May 25, 2016 · 14 comments

Comments

@gamestailer94
Copy link

if not something like this happens:
https://ci.appveyor.com/project/gamestailer94/quest-editor/build/1.0.64#L398

@develar
Copy link
Member

develar commented May 25, 2016

For windows consider only distributing 64-bit versions — see #359 (comment) Or use custom update server.

@develar develar closed this as completed May 25, 2016
@gamestailer94
Copy link
Author

gamestailer94 commented May 25, 2016

I use nuts as update server.
so I just need a Way for nuts to diferentiate between win x64 and ia32 releases.
As for the Auto update thing i have a workaround for that, its just the upload part of the builder...

and yes I need to have ia32

@develar
Copy link
Member

develar commented May 25, 2016

and yes I need to have ia32

Well, so, just distribute only ia32 as solution. Win64 can run ia32.

@gamestailer94
Copy link
Author

gamestailer94 commented May 25, 2016

Well, so, just distribute only ia32 as solution.

All I was askting was a arch suffix on window artifacts (like on linux builds)

@develar
Copy link
Member

develar commented May 25, 2016

All I was askting was a arch suffix on window artifacts (like on linux builds)

It was implemented earlier, but it leads to critical error — nupkg MUST NOT contain arch suffix because package name is present in the RELEASES file. So, we should fix update server AND Squirrel.Windows to use arch suffix in the package name. But it is unrealistic to fix Squirrel.Windows.

@gamestailer94
Copy link
Author

hmm, well ok if there is really no other way, then i will use ia32.

gamestailer94 added a commit to gamestailer94/quest-editor that referenced this issue May 25, 2016
@develar
Copy link
Member

develar commented May 25, 2016

There is solution — use other update server (not nuts because of GitbookIO/nuts#32) and host artifacts not on the Github. Maybe https://github.com/ArekSredzki/electron-release-server (S3 issue — ArekSredzki/electron-release-server#15)

@ArekSredzki I don't see in the project README that arch issue is solved, but I remember that actually it is fixed in your project :)

@ArekSredzki
Copy link

@develar yeah, electron-release-server has full arch support. It was never "broken" so didn't think to put it in the README. Feel free to put in a PR :)

This was referenced Jun 4, 2016
@ghost
Copy link

ghost commented Jun 12, 2016

mac naming issues too;

zip is named = "App Name-0.1.2-mac.zip"
dmg is named = "App Name-0.1.2.dmg"

(why does the zip version have "-mac"?)

@develar
Copy link
Member

develar commented Jun 13, 2016

why does the zip version have "-mac"

  • Squirrel.Mac requirement.
  • zip is a generic format — it is not clear — is it for OS X or Windows. zip for windows also has suffix -win.

@steverandy
Copy link
Contributor

@develar Will you be open to implement or accepting PR for supporting ia32 and x64 when publishing to github by using suffix?

I plan to build a custom update server that will handle serving files for both arch.

@develar
Copy link
Member

develar commented May 27, 2017

Yes. But please note — now default target is nsis.

@steverandy
Copy link
Contributor

@develar I think Squirrel.Windows supports suffix in the filename (Squirrel/Squirrel.Windows#450)

Will there be any issue if we use something like "appname-1.0.0-beta0-ia32-full.nupkg" in RELEASES?

@develar
Copy link
Member

develar commented May 28, 2017

I cannot advice. Nsis is recommended default target now. In any case, PR will be accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants