-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Different names for ia32 and win64 nupkg #439
Comments
For windows consider only distributing 64-bit versions — see #359 (comment) Or use custom update server. |
I use nuts as update server. and yes I need to have ia32 |
Well, so, just distribute only ia32 as solution. Win64 can run ia32. |
All I was askting was a arch suffix on window artifacts (like on linux builds) |
It was implemented earlier, but it leads to critical error — nupkg MUST NOT contain arch suffix because package name is present in the RELEASES file. So, we should fix update server AND Squirrel.Windows to use arch suffix in the package name. But it is unrealistic to fix Squirrel.Windows. |
hmm, well ok if there is really no other way, then i will use ia32. |
There is solution — use other update server (not nuts because of GitbookIO/nuts#32) and host artifacts not on the Github. Maybe https://github.com/ArekSredzki/electron-release-server (S3 issue — ArekSredzki/electron-release-server#15) @ArekSredzki I don't see in the project README that arch issue is solved, but I remember that actually it is fixed in your project :) |
@develar yeah, electron-release-server has full arch support. It was never "broken" so didn't think to put it in the README. Feel free to put in a PR :) |
mac naming issues too; zip is named = "App Name-0.1.2-mac.zip" (why does the zip version have "-mac"?) |
|
@develar Will you be open to implement or accepting PR for supporting ia32 and x64 when publishing to github by using suffix? I plan to build a custom update server that will handle serving files for both arch. |
Yes. But please note — now default target is nsis. |
@develar I think Squirrel.Windows supports suffix in the filename (Squirrel/Squirrel.Windows#450) Will there be any issue if we use something like "appname-1.0.0-beta0-ia32-full.nupkg" in RELEASES? |
I cannot advice. Nsis is recommended default target now. In any case, PR will be accepted. |
if not something like this happens:
https://ci.appveyor.com/project/gamestailer94/quest-editor/build/1.0.64#L398
The text was updated successfully, but these errors were encountered: