-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NSIS Auto-Update #529
Comments
@develar @kunkinkan How's this gonna work? Will it be analogue to Squirrel? |
@black-snow yes, only feed url will be changed in the user code. Auto-update API impl will be bundled. |
Great. How are things going? Any help needed? |
Will this be better than Squirrel auto-update? I don't like with them that I cannot control the process; I should be able to allow the user to choose whether or not to update to the newest version, instead of forcing it. (And also; better security. Allow me access to the downloaded auto-update so I can for example compare md5 hashes, etc). So a method after downloading the update to verify it. |
@atypicalprogrammer afaik Squirrel does verify checksums. |
@black-snow how do you figure? I'm talking about me providing a txt file with a checksum to compare with a downloaded file. It's a custom function that should be possible to provide better security. Something that is ran before the update itself is installed, simply a function that can cancel the further progression of install. The checksum validation I can add myself. |
Started to work on this. First version will support only Bintray:
|
any good news now? |
Miracles happens. Serverless macOS auto-update is implemented in the electron-builder 11.3.0 and electron-auto-updater 1.0.0 #1089 (comment) |
@develar thanks to make the miracle happen ! It is like Santa Claus came for a second round ! I Look forward to rip out my own hackish serverside workarounds. |
|
Does |
I'd like to configure nuts to be used as a generic https server if possible -- my repos are private & I still like having my artifacts published on github. |
@Timer, I have written a node Express server that does that. I can post the code if you want. |
That would be much appreciated @kevinphelps; it would save me quite a bit of time! Thanks! 💯 |
@Timer for your case I suggest amazon s3 — more robust because you don't need to maintain own server / https cert. You can be sure always that it works and uptime 100%. Yes, currently artifacts are not uploaded automatically, but you can file issue / use another tool to publish artifacts. |
@develar perhaps if I run into some free time I could make a small tool to do that -- but I was planning on using heroku anyway which is managed and has https. I still don't believe the docs are very clear explaining what is required from a generic server... Do I just need to host |
Yes. Nothing more. Create any path as you want in the bucket (e.g.
|
Can the link in |
@Timer Squirrel.Mac issue. Electron-builder cannot fix it. |
Neat @develar, thanks for all your help! |
@kevinphelps would love to see the Heroku app you made! My repos are private. Thanks for any and all time!
@Timer are you doing this manually each time you build? |
@aj-ptw Please file new issue about it. |
@Timer @aj-ptw I extracted my update server code and pushed it this repo: https://github.com/kevinphelps/electron-update-server. Let me know if you have any questions. Sorry if this seems overbuilt, I extracted it from my update/login/api server. It has all the groundwork for adding additional endpoints, though. |
Awesome @kevinphelps 💯! @aj-ptw I change it automatically -- see https://github.com/Timer/electron-release-s3-sync/blob/master/src/index.js#L97-L105. e.g. $ yarn add electron-release-s3-sync --dev
- or -
$ npm i electron-release-s3-sync --save-dev
$ ./node_modules/.bin/electron-release-s3-sync I also added it to my |
Using nuts as router for latest version (or as proxy for private GitHub repo): http://electron-builder.slackarchive.io/general/-/1485421231.000003/1485932834.000105/1485932834000105/ (slack link: https://electron-builder.slack.com/archives/general/p1485932834000105?thread_ts=1485886051.000072&cid=C3X4YCA14) |
I'm using |
@sylhero I've experienced the same thing, updating electron-builder to 13.x.x ( 13.3.1 in my case ) helped. |
where do these json and yml files come from? |
@ccorcos which files do you mean? |
yes: |
Creating this issue just to keep track of status, or when it is planned.
The text was updated successfully, but these errors were encountered: