-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AppImage files no longer runnable after upgrading to Electron-Builder@23.0.0 #6678
Comments
The only thing I can find that could potentially be related is updating upstream dependency, app-builder-bin, which was upgraded to support Snap compression IIRC v22.14.13...v23.0.0 Regarding the error, I did a quick search for other ways to resolve it and found this: https://www.reddit.com/r/debian/comments/k1kt96/comment/gdp80yp |
Thanks for the reply and research! The Downgrading to I do recall seeing something about downloading app-builder-bin, I think, on the first run with OS are Kubuntu 21.10 and Mint 20.2. |
I think it might be this commit on app-builder-bin? I honestly don't know a thing about AppImages |
Same problem in v23.0.1 Alert link: https://github.com/AppImage/AppImageKit/wiki/FUSE |
Curious if your issue is related to #6624 |
I tried builds of appImage versions of electron 13.6.8, 13.6.9, 16.0.8, none of them work:
This doesn't seem to be related to electron, falling back to electron-builder 22.x.x works again |
I'm wondering if compression is no longer optional param. Could you give this patch a try using patch-package? That should unblock you for the interim
|
@mmaietta Build fails after applying patch:
|
I hardcoded diff --git a/node_modules/app-builder-lib/out/targets/AppImageTarget.js b/node_modules/app-builder-lib/out/targets/AppImageTarget.js
index 31344b3..0be0fe4 100644
--- a/node_modules/app-builder-lib/out/targets/AppImageTarget.js
+++ b/node_modules/app-builder-lib/out/targets/AppImageTarget.js
@@ -75,13 +75,12 @@ class AppImageTarget extends core_1.Target {
fileAssociations: this.packager.fileAssociations,
...options,
}),
+ "--compression",
+ "gzip",
];
appBuilder_1.objectToArgs(args, {
license,
});
- if (packager.compression === "maximum") {
- args.push("--compression", "xz");
- }
await packager.info.callArtifactBuildCompleted({
file: artifactPath,
safeArtifactName: packager.computeSafeArtifactName(artifactName, "AppImage", arch, false), and then get the following error:
Hardcoding |
Seconding the slow startup with @mmaietta yes, this is exactly the issue I've been having with #6624, you're correct. |
I think if we can downgrade Either that, or we have to rollback to 3.x and hopefully not remove any recently introduced features. |
I can attest that downgrading app-builder-bin to 4.0.0 works:
|
That hack didn't work for me, with no compression setting enabled:
With |
Never mind, I still had the patch applied that mmaietta asked me to try. With a fresh node_modules folder it's working for me as well. I haven't tried snaps though, only appimage. |
If you applied the
|
@slapbox Would you be willing to open a ticket/issue in the app-builder repo regarding the broken I'll downgrade app-builder-bin to 4.0.0, it looks like it may drop snap lzo support though. Oh well...previous functionality shouldn't be broken. |
@mmaietta I'll be happy to help out however I can, but I'm not sure what repo corresponds to the npm package, because none is listed: https://www.npmjs.com/package/app-builder-bin Can you advise? Thank you for your hard work, it's truly appreciated. |
Nvm, I took a stab at it just by reading the error logs. I think it'll fix it, but as the PR says, I have no idea how to test it. @develar please take a look when you have a chance, that way we can have a proper fix in electron-builder without reverting lzo feature introduction. |
@mmaietta thanks for your continuing work on this! I'm sorry to report that using yarn's Here's the output of |
Is there any additional info to the error? Something like this? |
Unfortunately not, it seems. I'm checking the system logs - but maybe there's somewhere else I should look? All I see in the system logs is this line, immediately after the app fails to start:
Edit: Running it directly from the terminal like
|
@mmaietta same results here. I even tried applying your patches so that there's always a compression option passed through. Good news, both |
For what it's worth, I'm running Arch Linux and Slapbox appears to be using Ubuntu and AppImages are supposed to be fully self-contained anyway so I don't think there's anything distribution specific going on here. |
Thanks for the updates. Downgrading to 4.0.0 breaks a bunch of other tests with snaps, I'm still trying to figure out a graceful downgrade. |
Published in v23.0.2 🙂 |
Newly generated
AppImage
executables throw an error when executed: "Cannot mount AppImage, please check your FUSE setup"Upon downgrading to
22.x.x
, theAppImage
executables work perfectly again.The text was updated successfully, but these errors were encountered: