Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow disabling of webinstaller files to avoid confusion with actual installers #6575

Merged
merged 4 commits into from
Jan 25, 2022

Conversation

devinbinnie
Copy link
Contributor

This PR allows the disabling of web installer files for electron-updater when it is only expected that a full installer should be downloaded.

This prevents a potential flaw in which an attacker using a webinstaller could serve a package not authorized by the developer to the end-user with malicious code inside.

@changeset-bot
Copy link

changeset-bot bot commented Jan 24, 2022

🦋 Changeset detected

Latest commit: 233acfc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
electron-updater Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Jan 24, 2022

✔️ Deploy Preview for car-park-attendant-cleat-11576 ready!

🔨 Explore the source changes: 233acfc

🔍 Inspect the deploy log: https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/61f02f866cebba0008d9dce9

😎 Browse the preview: https://deploy-preview-6575--car-park-attendant-cleat-11576.netlify.app

@mmaietta
Copy link
Collaborator

mmaietta commented Jan 24, 2022

Please also add a .changeset file for this PR via pnpx changeset. Seems like it should be a major bump if we do default disableWebInstaller to true (completely fine since we're in a v23-alpha so we can include breaking changes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants