-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Optionally remove DISABLE_WAYLAND for snaps #6961
fix: Optionally remove DISABLE_WAYLAND for snaps #6961
Conversation
🦋 Changeset detectedLatest commit: 41c5fa5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for car-park-attendant-cleat-11576 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
This feels like a breaking change for electron-builder. I'm wondering if we can make this a feature instead by adding
Then What are your thoughts? |
Unfortunately I'm not sure if this would be a breaking change, but I'm happy to add an option to enable it in the meantime. Maybe in the future it could be enabled by default if a minimum known-working electron version is used. |
I'll have to use some different logic for setting DISABLE_WAYLAND because this expects it to be unset/"" for false, or a non-empty value for true. |
…iveWayland option * Update documentation for default plugs
Okay, I added that option. I wasn't able to update the docs locally because I haven't been able to get my local environment set up to compile this properly (pnpm install is complaining about yarn exiting with status 1). |
Fixes #6888