-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add the accelerate option for s3 buckets #7314
Conversation
🦋 Changeset detectedLatest commit: 2f09500 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for car-park-attendant-cleat-11576 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Curious. Why not set the
|
Sadly I tried that and it throws |
Ahh, I see. It gets pulled elsewhere via Okay, this seems fine to me. I can't see another way to decrease the wonky logic going on here without breaking backward compatibility. |
Currently it appears there's no support for the s3 accelerated bucket option.
Attempting to supply an endpoint causes the bucket to be appended on the URL, pushing the artifacts into a subfolder.
This PR adds the option to 'accelerate' the s3 bucket, where the s3 URL will be formatted as expected by s3.
For more information on s3 bucket acceleration and the expected URL formats, see:
https://docs.aws.amazon.com/AmazonS3/latest/userguide/transfer-acceleration.html
Let me know if I missed anything, I'm happy to throw this PR away if I am off the mark, or there's an easier way to achieve this.