Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow MAS builds to be unsigned if identity: null is explicitly passed #7382

Merged
merged 2 commits into from
Jan 18, 2023

Conversation

radex
Copy link
Contributor

@radex radex commented Jan 18, 2023

Currently, MAS builds are always signed, even if identity: null is explicitly passed. In fact, sign is called twice, first time ignored:

• skipped macOS code signing  reason=identity explicitly is set to null
  • signing         file=dist/mas-arm64/Nozbe.app identityName=xxxx identityHash=yyy provisioningProfile=none

It should be possible to force a MAS build to be unsigned. (in my use case, I need this because I need additional modifications to the app before it can be Universalized, and only then it can be signed)

@changeset-bot
Copy link

changeset-bot bot commented Jan 18, 2023

🦋 Changeset detected

Latest commit: 8566a90

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-builder Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Jan 18, 2023

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit 8566a90
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/63c829fc3586fc0008e2456c
😎 Deploy Preview https://deploy-preview-7382--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mmaietta mmaietta changed the title Allow MAS builds to be unsigned fix: Allow MAS builds to be unsigned if identity: null is explicitly passed Jan 18, 2023
@mmaietta mmaietta merged commit bb37687 into electron-userland:master Jan 18, 2023
@github-actions github-actions bot mentioned this pull request Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants