fix: install all dependencies to fix building within NPM workspaces

[beyondkmp]

fix #7103.

If node_modules doesn't exist at all, I think we can directly install all packages, not just the production ones. Even if we reinstall all packages under the workspace again, it shouldn't cause any issues.

At most, this approach would just take some extra time but won't lead to any problems.

[changeset-bot]

🦋 Changeset detected

Latest commit: 43375bf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages

Name	Type
app-builder-lib	Patch
dmg-builder	Patch
electron-builder-squirrel-windows	Patch
electron-builder	Patch
electron-forge-maker-appimage	Patch
electron-forge-maker-nsis-web	Patch
electron-forge-maker-nsis	Patch
electron-forge-maker-snap	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[mmaietta]

Is there a test project I can verify locally or unit test we could set up for this? (If it's too complex, then no worries, just wanted to double check though)

[mmaietta]

Can you check this? The main issue I think I see here is with the default configuration of electron-builder, where it includes all files in the project directory https://www.electron.build/contents#files. This means for projects already using electron-builder, this could lead to a dramatic increase in app size if they are relying on electron-builder to install their app dependencies as this PR will cause non-production dependencies to be packaged with it.

[beyondkmp]

Here's a test demo: https://github.com/electron-userland/electron-builder/files/9458943/test-workspace.zip.

[beyondkmp]

Can you check this? The main issue I think I see here is with the default configuration of electron-builder, where it includes all files in the project directory https://www.electron.build/contents#files. This means for projects already using electron-builder, this could lead to a dramatic increase in app size if they are relying on electron-builder to install their app dependencies as this PR will cause non-production dependencies to be packaged with it.

This shouldn't increase, when we copy node modules to asar, we filter for production dependencies and only copy those. Dev dependencies won't be copied, so it won't have any impact even if everything is installed.

[mmaietta]

Nice work!