Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(s3): add forcePathStyle option to S3Options #8741

Merged
merged 3 commits into from
Dec 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/four-gorillas-nail.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"builder-util": minor
"builder-util-runtime": minor
"electron-publish": minor
---

Add `forcePathStyle` option to S3Options
6 changes: 6 additions & 0 deletions packages/builder-util-runtime/src/publishOptions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -362,6 +362,12 @@ export interface S3Options extends BaseS3Options {
* ${bucketname}.s3-accelerate.amazonaws.com
*/
readonly accelerate?: boolean

/**
* When true, force a path-style endpoint to be used where the bucket name is part of the path.
* [Path-style Access](https://docs.aws.amazon.com/AmazonS3/latest/userguide/VirtualHosting.html#path-style-access)
*/
readonly forcePathStyle?: boolean
}

/**
Expand Down
2 changes: 1 addition & 1 deletion packages/builder-util/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"dependencies": {
"7zip-bin": "~5.2.0",
"@types/debug": "^4.1.6",
"app-builder-bin": "5.0.0-alpha.11",
"app-builder-bin": "5.0.0-alpha.12",
"bluebird-lst": "^1.0.9",
"builder-util-runtime": "workspace:*",
"chalk": "^4.1.2",
Expand Down
4 changes: 4 additions & 0 deletions packages/electron-publish/src/s3/s3Publisher.ts
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,10 @@ export class S3Publisher extends BaseS3Publisher {
if (this.info.encryption != null) {
args.push("--encryption", this.info.encryption)
}

if (this.info.forcePathStyle != null) {
args.push("--forcePathStyle", this.info.forcePathStyle ? "true" : "false")
}
}

toString() {
Expand Down
10 changes: 5 additions & 5 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading