Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use newer version of Electron #145

Merged
merged 1 commit into from
Apr 29, 2022
Merged

Conversation

erickzhao
Copy link
Member

Upgrades to the latest Electron stable release. Fixes tests not working on macOS arm64 machines since Electron 2 did not support Apple silicon.

@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #145 (57c7919) into main (b935f64) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #145   +/-   ##
=======================================
  Coverage   75.43%   75.43%           
=======================================
  Files           1        1           
  Lines          57       57           
=======================================
  Hits           43       43           
  Misses         14       14           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b935f64...57c7919. Read the comment docs.

@erickzhao erickzhao merged commit 0c4d573 into main Apr 29, 2022
@erickzhao erickzhao deleted the test/new-electron-version branch April 29, 2022 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant