Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Should show the download progress or some kind of information if the download is slow #236

Closed
MarshallOfSound opened this issue Mar 21, 2017 · 1 comment

Comments

@MarshallOfSound
Copy link
Member

If the download takes more than a certain amount of time (let's just say 2 minutes) we should enable the progress output of electron-download.

The current user experience is to see node install.js and then sit there on their slow internet connection wondering why on earth it is taking so long. Then the cancel it and start again not realizing it restarts the entire download and nothing was wrong in the first place.

I think the install flow should end up something like

npm i electron
# > executes node install.js
# Downloading prebuilt Electron binaries, on a slower internet connection this may time some time
# >Wait 2 minutes
# Looks like download Electron is taking a bit longer than normal, you can now see the download progress below
# [#####----------------------------] 20%

This way for the average user with decent internet the experience will be the same, for users with this "my terminal does nothing" issue we will at least be warning them it might take a while, and then giving the information they want to see after a given amount of time.

Feedback welcome, just a proposal 👍

@zeke
Copy link
Member

zeke commented Aug 8, 2017

The electron-prebuilt repo is being retired and its code has been moved into the electron/electron repo. For the sake of historical transparency, we will leave GitHub Issues enabled on this repository, but if you are still affected by the issue reported here, please open a new issue on electron/electron repo and reference this issue from it so people can get the full context. The electron repository has a large and active contributor community, so your issue is more likely to get the attention it deserves there. Thanks!

PS Love this idea. :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants