This repository has been archived by the owner on Oct 2, 2020. It is now read-only.
retire electron-prebuilt #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeke
requested review from
max-mapper,
mafintosh,
jkleinsc,
kevinsawicki and
vanessayuenn
jkleinsc
suggested changes
Aug 8, 2017
README.md
Outdated
| and are incrementally documenting and [improving our release process](https://github.com/electron/electron/blob/master/docs/development/releasing.md). | ||
| As we've added support for things like | ||
| [TypeScript definitions](https://electron.atom.io/blog/2017/06/01/typescript), | ||
| it's been challening to work these additions into the `electron` -> `electron-prebuilt-updater` -> `electron-prebuilt` release flow. |
There was a problem hiding this comment.
it's been challening should be it's been challenging
|
I love the |
vanessayuenn
approved these changes
Aug 8, 2017
This was referenced Aug 8, 2017
Closed
This was referenced Aug 8, 2017
Error: Generated checksum for "electron-v1.4.13-linux-x64.zip" did not match expected checksum.
#264
Closed
|
Update: Closed all open issues, encouraging folks to open followup issues on electron/electron if needed. |
|
It'd be nice if there was a bot that auto-closed new issues/PRs (with roughly the same message as @zeke's), but not required. Mostly because people have a tendency to automatically delete PR/issue template text, from my experience. |
Let's wait it out and see.
|
|
I think it's currently private. |
|
🔒 🔨 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
electronmodule will now be published to npm as part of the Electron release process, obviating the need forelectron-prebuiltand theelectron-prebuilt-updaterHeroku app. This repo's history has been imported wholesale into electron/electron. See electron/electron#10172 for technical details.This PR updates the README with info about the change and adds some backstory so people know what the role of this repo was in the past, and why we made the change.
We'll also sweep through the open issues and PRs here, migrating anything pertinent to electron/electron.