Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add linux deps #142

Merged
merged 1 commit into from
Apr 17, 2024
Merged

ci: add linux deps #142

merged 1 commit into from
Apr 17, 2024

Conversation

clavin
Copy link
Member

@clavin clavin commented Apr 17, 2024

Linux CI seems to fail due to missing system dependencies required to load chromedriver, which are added in this PR.

@clavin clavin marked this pull request as ready for review April 17, 2024 18:39
@clavin clavin requested a review from a team as a code owner April 17, 2024 18:39
dsanders11
dsanders11 requested changes Apr 17, 2024
View reviewed changes
Copy link
Member

@dsanders11 dsanders11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking merge temporarily just to see what happens with in-flight builds, will unblock in a couple hours.

@clavin
Copy link
Member Author

clavin commented Apr 17, 2024

Rebased & squashed after getting successful run: https://app.circleci.com/pipelines/github/electron/chromedriver/369/workflows/f3dccc80-036c-45bf-bba0-c45b726ec8c9/jobs/2970

  • Linux deps step ran
  • Node tests show that the test passed, not just skipped

dsanders11
dsanders11 approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@dsanders11 dsanders11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has probably been failing for a while and we're just now noticing because the old smoke test wasn't checking the output for Electron versions 7-29.

LGTM 👍

@dsanders11 dsanders11 merged commit e30eae5 into main Apr 17, 2024
3 checks passed
@dsanders11 dsanders11 deleted the fixify-linux-ci branch April 17, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsanders11 dsanders11 dsanders11 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clavin @dsanders11