chore: upgrade to Node.js v14.9.0 #25249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
changed the title
codebytere
force-pushed
the
nodejs-v14
branch
3 times, most recently
from
17156aa
to
5b5c169
Compare
codebytere
force-pushed
the
nodejs-v14
branch
13 times, most recently
from
182dd3f
to
799c17e
Compare
codebytere
changed the title
|
This PR is ready for initial review - arm CI is experiencing some Struggles™️ so i'll sort those out before looking to land this. |
codebytere
force-pushed
the
nodejs-v14
branch
4 times, most recently
from
79a00ae
to
a3a43b9
Compare
jkleinsc
approved these changes
Sep 15, 2020
This was previously broken - to make it work we need to figure out how to initialize inspector before RunBootstrapping() and we can do that as a follow-up
This behavior is no longer valid as of nodejs/node#29197
codebytere
force-pushed
the
nodejs-v14
branch
from
a3a43b9
to
6e94a57
Compare
codebytere
force-pushed
the
nodejs-v14
branch
from
6e94a57
to
2f7058c
Compare
MarshallOfSound
requested changes
Sep 16, 2020
|
@MarshallOfSound it's been resolved - just working on verifying one last thing with the net specs atm |
codebytere
force-pushed
the
nodejs-v14
branch
2 times, most recently
from
015c1de
to
73ba23b
Compare
codebytere
force-pushed
the
nodejs-v14
branch
from
73ba23b
to
28bc637
Compare
MarshallOfSound
approved these changes
Sep 17, 2020
|
Release Notes Persisted
|
|
Is this added to the v11 beta? This fixes an important issue about worker_thread and we hope we can adapt this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Upgrade Node.js to
v14.9.0Checklist
npm testpassesRelease Notes
Notes: Upgraded Node.js to v14.9.0.