fix: toggleDevTools menu role closes devtools window #29922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In my original issue, I don't use any menus. Will this fix still work for that? |
|
@pushkin- unfortunately no, Electron doesn't provide any non-Menu APIs for registering accelerators across the whole app. I think that could be a useful extension to the |
codebytere
reviewed
Jun 29, 2021
| @@ -143,7 +143,10 @@ export const roleList: Record<RoleId, Role> = { | |||
| label: 'Toggle Developer Tools', | |||
| accelerator: isMac ? 'Alt+Command+I' : 'Ctrl+Shift+I', | |||
| nonNativeMacOSRole: true, | |||
| windowMethod: w => w.webContents.toggleDevTools() | |||
| webContentsMethod: wc => { | |||
There was a problem hiding this comment.
can we test this? We should be able to trigger the role and then check isDevToolsOpened() i'd imagine?
zcbenz
approved these changes
Aug 2, 2021
|
Release Notes Persisted
|
BlackHole1
pushed a commit
to BlackHole1/electron
that referenced
this pull request
Aug 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes #28770.
webContents.getOwnerBrowserWindow()when called on a devtools webcontentsseems to return the BrowserWindow containing the webContents to which the
devtools is attached.
This probably doesn't work great for windows with BrowserViews in them, but
then, the previous implementation of this also didn't work correctly for that
case, so it's probably fine?
Checklist
npm testpassesRelease Notes
Notes: Fixed detached DevTools window not closing when a menu item with the toggleDevTools role was triggered.