Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bring --enable-logging functionality in line with Chromium (#25089) #29963

Merged
merged 1 commit into from
Jul 5, 2021

Conversation

nornagon
Copy link
Member

Backport of #25089.

Notes: Added support for directing Chromium logging to a file with --log-file=.../path/to/file.log. Also, it's now possible to enable logging from JavaScript by appending command-line switches during the first JS tick.

)

Co-authored-by: Jeremy Rose <jeremya@chromium.org>
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 30, 2021
@trop trop bot added 14-x-y backport This is a backport PR backport/requested 🗳 semver/minor backwards-compatible functionality labels Jun 30, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 30, 2021
Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on behalf of @electron/wg-releases

@zcbenz zcbenz merged commit aab2479 into 14-x-y Jul 5, 2021
@zcbenz zcbenz deleted the backport/14-x-y/refactor-logging branch July 5, 2021 06:29
@release-clerk
Copy link

release-clerk bot commented Jul 5, 2021

Release Notes Persisted

Added support for directing Chromium logging to a file with --log-file=.../path/to/file.log. Also, it's now possible to enable logging from JavaScript by appending command-line switches during the first JS tick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
14-x-y backport/approved ✅ backport This is a backport PR semver/minor backwards-compatible functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants