Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: typo in launch-app-from-url-in-another-app.md #30566

Merged
merged 2 commits into from
Aug 19, 2021
Merged

docs: typo in launch-app-from-url-in-another-app.md #30566

merged 2 commits into from
Aug 19, 2021

Conversation

LarryKlugerDS
Copy link
Contributor

@LarryKlugerDS LarryKlugerDS commented Aug 17, 2021 •
edited by zcbenz
Loading

Description of Change

Code snippet for the info.plist example had html formatting. Removed.

Checklist

Release Notes

Notes: none

@LarryKlugerDS
Typo in launch-app-from-url-in-another-app.md
f34735e 
Code snippet for the info.plist example had html formatting. Removed.
@welcome
Copy link

welcome bot commented Aug 17, 2021

💖 Thanks for opening this pull request! 💖

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 17, 2021
@LarryKlugerDS LarryKlugerDS changed the title Typo in launch-app-from-url-in-another-app.md docs: Typo in launch-app-from-url-in-another-app.md Aug 17, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 18, 2021
@zcbenz zcbenz changed the title docs: Typo in launch-app-from-url-in-another-app.md docs: typo in launch-app-from-url-in-another-app.md Aug 18, 2021
@zcbenz zcbenz merged commit 11de995 into electron:main Aug 19, 2021
@welcome
Copy link

welcome bot commented Aug 19, 2021

Congrats on merging your first pull request! 🎉🎉🎉

@release-clerk
Copy link

release-clerk bot commented Aug 19, 2021

No Release Notes

This was referenced Aug 19, 2021
Merged
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Aug 19, 2021

I have automatically backported this PR to "13-x-y", please check out #30626

@trop
Copy link
Contributor

trop bot commented Aug 19, 2021

I have automatically backported this PR to "14-x-y", please check out #30627

@trop trop bot removed the target/13-x-y label Aug 19, 2021
@trop
Copy link
Contributor

trop bot commented Aug 19, 2021

I have automatically backported this PR to "15-x-y", please check out #30628

BlackHole1 pushed a commit to BlackHole1/electron that referenced this pull request Aug 30, 2021
@LarryKlugerDS @BlackHole1
docs: typo in launch-app-from-url-in-another-app.md (electron#30566)
4ff95aa 
* Typo in launch-app-from-url-in-another-app.md

Code snippet for the info.plist example had html formatting. Removed.

* Fix paddings

Co-authored-by: Cheng Zhao <github@zcbenz.com>
malept added a commit to malept/electron that referenced this pull request Sep 8, 2021
@malept
docs(protocols): simplify packaging section & cleanup
ba89dcc 
Backport of electron#30194
Backport of electron#30566
Backport of electron#30832
@malept malept mentioned this pull request Sep 8, 2021
Merged
@trop
Copy link
Contributor

trop bot commented Sep 8, 2021

@malept has manually backported this PR to "15-x-y", please check out #30881

@trop trop bot added the in-flight/15-x-y label Sep 8, 2021
zcbenz pushed a commit that referenced this pull request Sep 8, 2021
@malept
docs(protocols): simplify packaging section & cleanup (#30881)
2724456 
Backport of #30194
Backport of #30566
Backport of #30832
@trop trop bot removed the in-flight/15-x-y label Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

Assignees
No one assigned
Labels
documentation 📓 semver/none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LarryKlugerDS @zcbenz