Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix flake under Rosetta #1620

Merged
merged 1 commit into from
Jul 30, 2024
Merged

test: fix flake under Rosetta #1620

merged 1 commit into from
Jul 30, 2024

Conversation

dsanders11
Copy link
Member

@dsanders11 dsanders11 commented Jul 30, 2024 •
edited
Loading

Follow-up to #1537. Re-ran the workflow 5 times to confirm it didn't flake.

Screenshot 2024-07-30 at 4 04 01 PM

@coveralls
Copy link

Coverage Status

coverage: 87.514%. remained the same
when pulling a071d00 on test/fix-flake
into 080508f on main.

@dsanders11 dsanders11 marked this pull request as ready for review July 30, 2024 23:04
@dsanders11 dsanders11 requested review from codebytere and a team as code owners July 30, 2024 23:04
erickzhao
erickzhao approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay :)

@dsanders11 dsanders11 merged commit 5b3dce7 into main Jul 30, 2024
10 checks passed
@dsanders11 dsanders11 deleted the test/fix-flake branch July 30, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erickzhao erickzhao erickzhao approved these changes

@codebytere codebytere Awaiting requested review from codebytere codebytere is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dsanders11 @coveralls @erickzhao