refactor(plugin-webpack): extract production __dirname code to its ow…

…n method
electron · Jul 23, 2021 · 2daf053 · 2daf053
1 parent 4fda813
commit 2daf053
Showing 1 changed file with 16 additions and 13 deletions.
diff --git a/packages/plugin/webpack/src/util/AssetRelocatorPatch.ts b/packages/plugin/webpack/src/util/AssetRelocatorPatch.ts
@@ -10,6 +10,21 @@ export default class AssetRelocatorPatch {
     this.nodeIntegration = nodeIntegration;
   }
 
+  private injectedProductionDirnameCode(): string {
+    if (this.nodeIntegration) {
+      // In production the assets are found one directory up from
+      // __dirname
+      //
+      // __dirname cannot be used directly until this PR lands
+      // https://github.com/jantimon/html-webpack-plugin/pull/1650
+      return 'require("path").resolve(require("path").dirname(__filename), "..")';
+    }
+
+    // If nodeIntegration is disabled, we replace __dirname
+    // with an empty string so no error is thrown at runtime
+    return '""';
+  }
+
   public apply(compiler: Compiler) {
     compiler.hooks.compilation.tap(
       'asset-relocator-forge-patch',
@@ -36,19 +51,7 @@ export default class AssetRelocatorPatch {
                 }
 
                 if (this.isProd) {
-                  return originalInjectCode.replace(
-                    '__dirname',
-                    this.nodeIntegration
-                      // In production the assets are found one directory up from
-                      // __dirname
-                      //
-                      // __dirname cannot be used directly until this PR lands
-                      // https://github.com/jantimon/html-webpack-plugin/pull/1650
-                      ? 'require("path").resolve(require("path").dirname(__filename), "..")'
-                      // If nodeIntegration is disabled, we replace __dirname
-                      // with an empty string so no error is thrown at runtime
-                      : '""',
-                  );
+                  return originalInjectCode.replace('__dirname', this.injectedProductionDirnameCode());
                 }
 
                 return originalInjectCode.replace(