feat(publisher-s3): Add sessionToken and change default fallback (#2984)

electron · Oct 27, 2022 · 72b80a7 · 72b80a7
1 parent 11a2f15
commit 72b80a7
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 5 deletions.
diff --git a/packages/publisher/s3/src/Config.ts b/packages/publisher/s3/src/Config.ts
@@ -2,16 +2,24 @@ export interface PublisherS3Config {
   /**
    * Your AWS Access Key ID
    *
-   * Falls back to the AWS_ACCESS_KEY_ID environment variable if not provided
+   * Falls back to the the default credential provider chain if not
+   * provided
    */
   accessKeyId?: string;
   /**
    * The secret for your AWS Access Key
    *
-   * Falls back to the AWS_SECRET_ACCESS_KEY environment variable if not
+   * Falls back to the the default credential provider chain if not
    * provided
    */
   secretAccessKey?: string;
+  /**
+   * The session token for your AWS Access Key
+   *
+   * Falls back to the the default credential provider chain if not
+   * provided
+   */
+  sessionToken?: string;
   /**
    * The name of the S3 bucket to upload artifacts to
    */

diff --git a/packages/publisher/s3/src/PublisherS3.ts b/packages/publisher/s3/src/PublisherS3.ts
@@ -90,11 +90,12 @@ export default class PublisherS3 extends PublisherBase<PublisherS3Config> {
   }
 
   generateCredentials(): Credentials | undefined {
-    const accessKeyId = this.config.accessKeyId || process.env.AWS_ACCESS_KEY_ID;
-    const secretAccessKey = this.config.secretAccessKey || process.env.AWS_SECRET_ACCESS_KEY;
+    const accessKeyId = this.config.accessKeyId;
+    const secretAccessKey = this.config.secretAccessKey;
+    const sessionToken = this.config.sessionToken;
 
     if (accessKeyId && secretAccessKey) {
-      return { accessKeyId, secretAccessKey };
+      return { accessKeyId, secretAccessKey, sessionToken };
     }
 
     return undefined;