fix(publisher): remove deprecated option from @octokit/rest params

This broke with @octokit/rest.js 15.2.0 ISSUES CLOSED: #493
electron · May 4, 2018 · e3da8c0 · e3da8c0
1 parent 049055c
commit e3da8c0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/src/util/github.js b/src/util/github.js
@@ -4,7 +4,6 @@ import merge from 'lodash.merge';
 export default class GitHub {
   constructor(authToken, requireAuth, options = {}) {
     this.options = merge(
-      { protocol: 'https' },
       options,
       { headers: { 'user-agent': 'Electron Forge' } }
     );

diff --git a/test/fast/github_spec.js b/test/fast/github_spec.js
@@ -46,17 +46,12 @@ describe('GitHub', () => {
 
     it('should be able to set the Enterprise URL settings', () => {
       const gh = new GitHub('1234', true, {
-        host: 'github.example.com',
-        port: 8443,
-        pathPrefix: '/enterprise',
+        baseUrl: 'https://github.example.com:8443/enterprise',
       });
       const api = gh.getGitHub();
 
       expect(api.options).to.deep.equal({
-        protocol: 'https',
-        host: 'github.example.com',
-        port: 8443,
-        pathPrefix: '/enterprise',
+        baseUrl: 'https://github.example.com:8443/enterprise',
         headers: {
           'user-agent': 'Electron Forge',
         },