-
-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webpack: packaged app has incorrect reference to renderer index.js #1034
Labels
Comments
My fix in #1021 was incorrect. I'll do a new PR. |
Much appreciated! |
#1035 should be at the right place this time |
5 tasks
malept
pushed a commit
that referenced
this issue
Jul 17, 2019
This reverts improper PR#1021 and re-implements the changes I have in the JS (compiled) code at the right place. Fixes #1034.
The path for the index.js seems to be correct in the 6.0.0-beta.43 but some css I am importing in the
The packaged app is looking at the |
dsanders11
pushed a commit
that referenced
this issue
Jan 14, 2023
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3.1.0 to 3.1.1. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v3.1.0...v3.1.1) --- updated-dependencies: - dependency-name: actions/setup-node dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Preflight Checklist
Issue Details
Please describe your issue:
When a Forge project using the Webpack template is packaged, the renderer file should be referenced as
../main_window/index.js
, not/main_window/index.js
.Please provide either a failing minimal testcase (with a link to the code) or detailed steps to
reproduce your problem. Using
electron-forge init
is a good starting point, if that is not thesource of your problem.
On Linux:
Please note: this bug is confirmed. Any comment that says anything to the effect of "I also have this problem" will be minimized.
The text was updated successfully, but these errors were encountered: