Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v6 doesn't name artifacts correctly for Windows nupgk #1245

Closed
3 tasks done
ahallicks opened this issue Oct 17, 2019 · 0 comments · Fixed by #1320
Closed
3 tasks done

v6 doesn't name artifacts correctly for Windows nupgk #1245

ahallicks opened this issue Oct 17, 2019 · 0 comments · Fixed by #1320

Comments

@ahallicks
Copy link

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • I have searched the issue tracker for an issue that matches the one I want to file, without success.

Please describe your issue:
When I run npm run publish it creates a nupkg file and the setup.exe. My version is set to 3.0.0-beta.3.

The setup file has this exact version (AppName-3.0.0-beta.3-Setup.exe) but the nupgk file is AppName-3.0.0-beta3-full.nupkg.

Notice the missing . in the beta bit. It then can't upload the assets as it's looking for a file with the name AppName-3.0.0-beta.3-full.nupkg.

Console output when you run electron-forge with the environment variable DEBUG=electron-forge:*. (Instructions on how to do so here). Please include the stack trace if one exists.

I'll do this when I'm back at my computer! 

What command line arguments are you passing?

Just

npm run package

What does your config.forge data in package.json look like?

IOU one config 

Please provide either a failing minimal testcase (with a link to the code) or detailed steps to
reproduce your problem. Using electron-forge init is a good starting point, if that is not the
source of your problem.

Seems to specifically be for beta where that extra . isn't added to the name so any simple app will fail in the same way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant