Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(maker-windows): handle versions with prerelease information #1320

Merged
merged 5 commits into from
Dec 4, 2019

Conversation

malept
Copy link
Member

@malept malept commented Dec 4, 2019

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

The WiX and Squirrel makers don't handle prerelease information in the version, so we need to handle it in a similar manner to the AppX maker (except not making the user set a flag to normalize the version).

Fixes #1245.

@malept malept merged commit d4e402d into electron:master Dec 4, 2019
@malept malept deleted the fix-nupkg-version branch December 4, 2019 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v6 doesn't name artifacts correctly for Windows nupgk
1 participant