Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish does not find generated deb alpha package #583

Closed
just-paja opened this issue Sep 30, 2018 · 3 comments · Fixed by electron-userland/electron-installer-debian#144
Labels

Comments

@just-paja
Copy link

  • [*] I have read the contribution documentation for this project.
  • [*] I agree to follow the code of conduct that this project follows, as appropriate.
  • [*] I have searched the issue tracker for an issue that matches the one I want to file, without success.

I named my first version 0.1.0-alpha-1 and ran publish dry-run and then from-dry-run command, but electron-forge ended with a following error:

Attempted to resume a dry run but an artifact (/home/circleci/repo/dist/electron/out/make/radio-drama-soundboard_0.1.0-alpha-1_amd64.deb) could not be found

The problem is that such a version is renamed by the deb packager to this:

radio-drama-soundboard_0.1.0~alpha-1_amd64.deb

Notice the tilde separating major.minor.patch and metadata. The version name is valid from perspective of semver 2.0.

What command line arguments are you passing?

electron-forge publish --dry-run -p linux
electron-forge publish --from-dry-run -p linux

What does your config.forge data in package.json look like?

"forge": {
      "make_targets": {
        "win32": [
          "squirrel"
        ],
        "darwin": [
          "zip"
        ],
        "linux": [
          "deb",
          "rpm"
        ]
      },
      "electronPackagerConfig": {
        "packageManager": "npm",
        "asar": true
      },
      "electronWinstallerConfig": {
        "name": "radio_drama_soundboard"
      },
      "electronInstallerDebian": {},
      "electronInstallerRedhat": {},
      "github_repository": {
        "owner": "just-paja",
        "name": "radio-drama-soundboard"
      },
      "windowsStoreConfig": {
        "packageName": "",
        "name": "radiodramasoundboard"
      }
    }
@malept
Copy link
Member

malept commented Oct 3, 2018

I'm starting to fix this here: electron-userland/electron-installer-debian#144

@malept
Copy link
Member

malept commented Oct 4, 2018

Oops, didn't mean to close this via electron-installer-debian.

@malept malept reopened this Oct 4, 2018
MarshallOfSound pushed a commit that referenced this issue Oct 9, 2018
…584)

* fix(maker-deb): return the correct outPath with a prerelease version

ISSUES CLOSED: #583

* chore(generic): upgrade node-abi to avoid warning
dsanders11 pushed a commit that referenced this issue Jan 14, 2023
* chore: Update dependencies

* fix: Update .eslintrc

* fix: Make standard & eslint play nice

* fix: Automatically install husky

* chore: Cleanup

* fix: Sad: No react update

* chore: Some more React downgrades
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants