Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(maker): allow Linux makers to run on non-Linux hosts if possible #1082

Merged
merged 2 commits into from
Aug 9, 2019

Conversation

malept
Copy link
Member

@malept malept commented Aug 8, 2019

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Adds a method that checks for the binaries required for a maker to run. For example, @electron-forge/maker-deb requires dpkg and fakeroot.

Fixes #539.

@malept malept force-pushed the relax-maker-platform-restrictions branch from cf21e2d to 8e729a1 Compare August 8, 2019 15:34
@malept malept requested a review from MarshallOfSound August 8, 2019 21:09
@malept malept marked this pull request as ready for review August 8, 2019 21:09
@malept
Copy link
Member Author

malept commented Aug 8, 2019

@MarshallOfSound I wonder if we should delegate this to the installer modules. But that would require us to require() the modules much earlier in the workflow, I think.

@malept
Copy link
Member Author

malept commented Aug 9, 2019

Let's start with this and we can change it later if we want.

@malept malept merged commit ec7db01 into master Aug 9, 2019
@malept malept deleted the relax-maker-platform-restrictions branch August 9, 2019 16:33
dsanders11 pushed a commit that referenced this pull request Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relax and/or Improve Checks in Makers’ isSupportedOnCurrentPlatform()
1 participant