Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-webpack): add missing debug level for webpack-dev-middleware #1131

Merged
merged 1 commit into from
Sep 4, 2019
Merged

fix(plugin-webpack): add missing debug level for webpack-dev-middleware #1131

merged 1 commit into from
Sep 4, 2019

Conversation

thateverdmitriy
Copy link
Contributor

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Tried to bootstrap new Electron app with elector-forge (TS + plugin-webpack). Got such error:

An unhandled exception has occurred inside Forge:
log.debug is not a function
TypeError: log.debug is not a function
    at /Users/project/node_modules/webpack-dev-middleware/lib/fs.js:63:21
    at /Users/project/node_modules/graceful-fs/graceful-fs.js:57:14
    at FSReqCallback.oncomplete (fs.js:153:23)

Thought it could be on my end and tried to create brand new project following setup guide:

$ yarn create electron-app my-new-app --template=webpack

It fail with same error as well. After checking where problem actually appears, found that webpack-dev-middleware has log.debug method in use: https://github.com/webpack/webpack-dev-middleware/blob/master/lib/fs.js#L63

In their README they mention debug as required logger level as well: https://github.com/webpack/webpack-dev-middleware#logger

plugin-webpack has debug logger level missing. One-line fix solving the issue.

Copy link
Member

@malept malept left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder what changed in webpack-dev-middleware to cause this. I checked the changelog very briefly and didn't see anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants