Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(maker-base): throw a better error when external binaries are missing #1306

Merged
merged 4 commits into from
Nov 30, 2019

Conversation

malept
Copy link
Member

@malept malept commented Nov 27, 2019

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Fixes #1262.

@codecov
Copy link

codecov bot commented Nov 30, 2019

Codecov Report

Merging #1306 into master will increase coverage by 0.29%.
The diff coverage is 86.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1306      +/-   ##
==========================================
+ Coverage   68.03%   68.32%   +0.29%     
==========================================
  Files          69       69              
  Lines        2002     2011       +9     
  Branches      383      381       -2     
==========================================
+ Hits         1362     1374      +12     
  Misses        471      471              
+ Partials      169      166       -3
Impacted Files Coverage Δ
packages/maker/deb/src/MakerDeb.ts 94.73% <100%> (+5.84%) ⬆️
packages/maker/base/src/Maker.ts 71.42% <100%> (+3.68%) ⬆️
packages/maker/flatpak/src/MakerFlatpak.ts 86.95% <100%> (+5.13%) ⬆️
packages/maker/rpm/src/MakerRpm.ts 94.73% <100%> (+5.84%) ⬆️
packages/maker/snap/src/MakerSnap.ts 100% <100%> (ø) ⬆️
packages/api/core/src/api/make.ts 70.78% <33.33%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0c15d9...cb65690. Read the comment docs.

@malept malept merged commit c8baa1e into master Nov 30, 2019
@malept malept deleted the better-external-binary-error branch November 30, 2019 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disambiguating deb and rpm packages
1 participant