Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace indexOf with includes/startsWith where applicable #1337

Merged
merged 2 commits into from
Dec 12, 2019

Conversation

malept
Copy link
Member

@malept malept commented Dec 12, 2019

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

This is a more complete version of #1305.

Closes #1305.

@codecov
Copy link

codecov bot commented Dec 12, 2019

Codecov Report

Merging #1337 into master will increase coverage by 0.6%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1337     +/-   ##
=========================================
+ Coverage   68.28%   68.89%   +0.6%     
=========================================
  Files          70       70             
  Lines        2040     2038      -2     
  Branches      383      382      -1     
=========================================
+ Hits         1393     1404     +11     
+ Misses        473      459     -14     
- Partials      174      175      +1
Impacted Files Coverage Δ
packages/api/core/src/api/publish.ts 75.32% <ø> (ø) ⬆️
packages/api/core/src/api/make.ts 70.78% <0%> (+5.61%) ⬆️
packages/plugin/webpack/src/WebpackPlugin.ts 30.67% <0%> (+0.25%) ⬆️
packages/api/core/src/api/install.ts 79.74% <0%> (ø) ⬆️
packages/api/core/src/api/import.ts 58.41% <0%> (ø) ⬆️
packages/maker/dmg/src/MakerDMG.ts 100% <0%> (+5.55%) ⬆️
packages/api/core/src/util/electron-version.ts 96.07% <0%> (+7.84%) ⬆️
packages/maker/zip/src/MakerZIP.ts 100% <0%> (+9.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 006d62f...cc6f3c3. Read the comment docs.

@malept malept merged commit a3eae4d into master Dec 12, 2019
@malept malept deleted the includes branch December 12, 2019 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant