Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): use loadFile instead of loadURL in the default template #1341

Merged
merged 1 commit into from
Dec 12, 2019

Conversation

malept
Copy link
Member

@malept malept commented Dec 12, 2019

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Fixes #1339.

@codecov
Copy link

codecov bot commented Dec 12, 2019

Codecov Report

Merging #1341 into master will decrease coverage by 24.9%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1341       +/-   ##
===========================================
- Coverage   66.43%   41.53%   -24.91%     
===========================================
  Files          70        4       -66     
  Lines        2038      183     -1855     
  Branches      382       37      -345     
===========================================
- Hits         1354       76     -1278     
+ Misses        533       95      -438     
+ Partials      151       12      -139
Impacted Files Coverage Δ
packages/api/core/src/api/import.ts 26% <0%> (-32.42%) ⬇️
packages/maker/snap/src/MakerSnap.ts
...es/api/core/src/api/init-scripts/init-directory.ts
packages/api/core/src/util/index.ts
packages/api/core/src/util/publish-state.ts
packages/utils/async-ora/src/index.ts
packages/maker/wix/src/util/author-name.ts
packages/plugin/webpack/src/WebpackPlugin.ts
packages/maker/rpm/src/MakerRpm.ts
packages/installer/base/src/Installer.ts
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29470fb...36d41fa. Read the comment docs.

@malept malept merged commit 51fbf71 into master Dec 12, 2019
@malept malept deleted the use-loadfile-instead-of-loadurl branch December 12, 2019 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App not starting when current working dir contains '#'
1 participant