Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add typescript-webpack template #1344

Merged
merged 2 commits into from
Dec 14, 2019
Merged

Conversation

codebytere
Copy link
Member

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Adds a new template for Webpack + TypeScript.

cc @malept @MarshallOfSound

@codecov
Copy link

codecov bot commented Dec 13, 2019

Codecov Report

Merging #1344 into master will decrease coverage by 1.38%.
The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1344      +/-   ##
==========================================
- Coverage   68.56%   67.17%   -1.39%     
==========================================
  Files          70       71       +1     
  Lines        2042     2078      +36     
  Branches      383      387       +4     
==========================================
- Hits         1400     1396       -4     
- Misses        461      524      +63     
+ Partials      181      158      -23
Impacted Files Coverage Δ
...ypescript-webpack/src/TypeScriptWebpackTemplate.ts 94.44% <94.44%> (ø)
packages/maker/squirrel/src/MakerSquirrel.ts 30% <0%> (-45%) ⬇️
packages/maker/wix/src/MakerWix.ts 40% <0%> (-45%) ⬇️
packages/maker/appx/src/MakerAppX.ts 19.64% <0%> (-35.72%) ⬇️
packages/maker/wix/src/util/author-name.ts 80% <0%> (-10%) ⬇️
packages/maker/appx/src/util/author-name.ts 80% <0%> (-10%) ⬇️
packages/maker/base/src/Maker.ts 70.27% <0%> (-2.71%) ⬇️
packages/api/core/src/api/import.ts 58.41% <0%> (+2.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1412e5...26ccf20. Read the comment docs.

@MarshallOfSound MarshallOfSound merged commit 7c8259d into master Dec 14, 2019
@MarshallOfSound MarshallOfSound deleted the ts-webpack-template branch December 14, 2019 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants