-
-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(template-typescript): use main script to start app #1345
Conversation
330584c
to
717e8f9
Compare
Codecov Report
@@ Coverage Diff @@
## master #1345 +/- ##
===========================================
+ Coverage 40.43% 68.56% +28.12%
===========================================
Files 4 70 +66
Lines 183 2042 +1859
Branches 37 383 +346
===========================================
+ Hits 74 1400 +1326
- Misses 96 459 +363
- Partials 13 183 +170
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll merge when tests pass.
Hey I'm new to electron, and want to figure out how to develop my first electron app using typescript and webpack. Your PR is exactly what I need (thanks!). I tried electron-webpack before but it's hard to write my webpack config since they hide everything so deeply. Now I use your template to init a empty project, but get stuck with
It's failed. Then I see this pull request and try:
It's also failed. Finally I try typescript template with CLI:
It passed. But I can't see anything about typescript in it. The folder looks like this: Did I make any mistakes? Or maybe it means I should wait until the template release... electron-forge is awesome. Thanks a million. |
This template has been released in beta 47, published a few seconds ago. |
Summarize your changes:
Fixes up the scripts to set
main
inpackage.json
to dist instead of baking it into the start script.