Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: create the ElectronProcess type (ChildProcess + restarted property) #1346

Merged
merged 1 commit into from
Dec 14, 2019

Conversation

malept
Copy link
Member

@malept malept commented Dec 13, 2019

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

This avoids the (process as any).restarted idiom.

@malept malept force-pushed the electronprocess-type branch from 6d5dd1c to 1f0a728 Compare December 13, 2019 18:57
@codecov
Copy link

codecov bot commented Dec 13, 2019

Codecov Report

Merging #1346 into master will decrease coverage by 26.24%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1346       +/-   ##
===========================================
- Coverage   66.68%   40.43%   -26.25%     
===========================================
  Files          70        4       -66     
  Lines        2041      183     -1858     
  Branches      383       37      -346     
===========================================
- Hits         1361       74     -1287     
+ Misses        523       96      -427     
+ Partials      157       13      -144
Impacted Files Coverage Δ
packages/api/core/src/api/import.ts 26% <0%> (-32.42%) ⬇️
packages/maker/snap/src/MakerSnap.ts
...es/api/core/src/api/init-scripts/init-directory.ts
packages/api/core/src/util/index.ts
packages/api/core/src/util/publish-state.ts
packages/utils/async-ora/src/index.ts
packages/maker/wix/src/util/author-name.ts
packages/maker/rpm/src/MakerRpm.ts
packages/installer/base/src/Installer.ts
packages/maker/appx/src/util/author-name.ts
... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01c417d...90cdbae. Read the comment docs.

@malept malept force-pushed the electronprocess-type branch from 66fbc06 to 90cdbae Compare December 14, 2019 02:11
@malept malept merged commit abbf031 into master Dec 14, 2019
@malept malept deleted the electronprocess-type branch December 14, 2019 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant