Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web-multi-logger): xterm 4 compatibility #1387

Merged
merged 1 commit into from
Jan 9, 2020
Merged

Conversation

malept
Copy link
Member

@malept malept commented Jan 9, 2020

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Missed fixing breaking changes when doing the initial upgrade.

Missed fixing breaking changes when doing the initial upgrade
@codecov
Copy link

codecov bot commented Jan 9, 2020

Codecov Report

Merging #1387 into master will decrease coverage by 2.54%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1387      +/-   ##
=========================================
- Coverage   70.05%   67.5%   -2.55%     
=========================================
  Files          72      72              
  Lines        2097    2099       +2     
  Branches      389     389              
=========================================
- Hits         1469    1417      -52     
- Misses        454     529      +75     
+ Partials      174     153      -21
Impacted Files Coverage Δ
packages/utils/web-multi-logger/src/Logger.ts 21.05% <0%> (-2.48%) ⬇️
packages/maker/squirrel/src/MakerSquirrel.ts 30% <0%> (-45%) ⬇️
packages/maker/wix/src/MakerWix.ts 40% <0%> (-45%) ⬇️
packages/maker/appx/src/MakerAppX.ts 19.64% <0%> (-35.72%) ⬇️
packages/api/core/src/util/electron-version.ts 84.31% <0%> (-11.77%) ⬇️
packages/maker/wix/src/util/author-name.ts 80% <0%> (-10%) ⬇️
packages/maker/appx/src/util/author-name.ts 80% <0%> (-10%) ⬇️
packages/maker/zip/src/MakerZIP.ts 90.9% <0%> (-9.1%) ⬇️
packages/api/core/src/api/make.ts 65.16% <0%> (-5.62%) ⬇️
packages/maker/dmg/src/MakerDMG.ts 94.44% <0%> (-5.56%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b8a2a6...101e85b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant