Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): avoid forEach and increase test coverage for forge-config #1395

Merged
merged 1 commit into from
Jan 13, 2020

Conversation

malept
Copy link
Member

@malept malept commented Jan 13, 2020

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Also fixes an edge case with config templates.

@malept malept force-pushed the fix-forge-config-edge-cases branch from 6b79717 to 932a383 Compare January 13, 2020 22:03
@codecov
Copy link

codecov bot commented Jan 13, 2020

Codecov Report

Merging #1395 into master will increase coverage by 2.57%.
The diff coverage is 90.9%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1395      +/-   ##
==========================================
+ Coverage    67.6%   70.17%   +2.57%     
==========================================
  Files          72       72              
  Lines        2099     2099              
  Branches      389      389              
==========================================
+ Hits         1419     1473      +54     
+ Misses        525      452      -73     
- Partials      155      174      +19
Impacted Files Coverage Δ
packages/api/core/src/util/forge-config.ts 80.3% <90.9%> (+12.12%) ⬆️
packages/maker/flatpak/src/MakerFlatpak.ts 78.26% <0%> (-8.7%) ⬇️
packages/api/core/src/api/import.ts 58.82% <0%> (ø) ⬆️
packages/maker/base/src/Maker.ts 72.97% <0%> (+2.7%) ⬆️
packages/maker/dmg/src/MakerDMG.ts 100% <0%> (+5.55%) ⬆️
packages/api/core/src/api/make.ts 70.78% <0%> (+5.61%) ⬆️
packages/maker/zip/src/MakerZIP.ts 100% <0%> (+9.09%) ⬆️
packages/maker/wix/src/util/author-name.ts 90% <0%> (+10%) ⬆️
packages/maker/appx/src/util/author-name.ts 90% <0%> (+10%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dc0401...932a383. Read the comment docs.

@malept malept merged commit 4db41a4 into master Jan 13, 2020
@malept malept deleted the fix-forge-config-edge-cases branch January 13, 2020 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant