Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-webpack): change preload target from electron-renderer to electron-preload #1521

Merged
merged 4 commits into from
Feb 28, 2020

Conversation

malept
Copy link
Member

@malept malept commented Feb 27, 2020

Summarize your changes:

Added in Webpack 4.33.0.

See also:

@malept malept force-pushed the webpack-change-preload-target branch from a9c43c4 to 2285b0e Compare February 27, 2020 19:54
@malept malept force-pushed the webpack-change-preload-target branch from abda669 to a9811a6 Compare February 28, 2020 18:40
@codecov
Copy link

codecov bot commented Feb 28, 2020

Codecov Report

Merging #1521 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1521   +/-   ##
=======================================
  Coverage   74.96%   74.96%           
=======================================
  Files          73       73           
  Lines        2121     2121           
  Branches      399      399           
=======================================
  Hits         1590     1590           
- Misses        407      409    +2     
+ Partials      124      122    -2     
Impacted Files Coverage Δ
packages/maker/base/src/Maker.ts 72.97% <0.00%> (ø) ⬆️
packages/api/core/src/util/rebuild.ts 92.85% <0.00%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fd31fb...7c6359f. Read the comment docs.

@malept malept merged commit 5f1b240 into master Feb 28, 2020
@malept malept deleted the webpack-change-preload-target branch February 28, 2020 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant