Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(template-base): update Travis CI config to best practices #1539

Merged
merged 1 commit into from
Mar 3, 2020

Conversation

malept
Copy link
Member

@malept malept commented Mar 2, 2020

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Just things I noticed when I was looking at the Electron Fiddle CI config.

@codecov
Copy link

codecov bot commented Mar 3, 2020

Codecov Report

Merging #1539 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1539   +/-   ##
=======================================
  Coverage   74.96%   74.96%           
=======================================
  Files          73       73           
  Lines        2121     2121           
  Branches      399      399           
=======================================
  Hits         1590     1590           
  Misses        407      407           
  Partials      124      124           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f1b240...abe3aab. Read the comment docs.

@malept malept merged commit a34656b into master Mar 3, 2020
@malept malept deleted the update-travis-ci-template branch March 3, 2020 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant